Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: retry on error on tikv ingest like 'stale command' #36878

Merged
merged 2 commits into from
Aug 4, 2022
Merged

lightning: retry on error on tikv ingest like 'stale command' #36878

merged 2 commits into from
Aug 4, 2022

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Aug 4, 2022

What problem does this PR solve?

Issue Number: close #36877

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter D3Hunter added the component/lightning This issue is related to Lightning of TiDB. label Aug 4, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-6.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 4, 2022

/cc @niubell @gozssky @buchuitoudegou

@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f424bc3cdbae9b9225294c75dcd11f1af775a142

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 4, 2022

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 4, 2022

/cc @dsdashun

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 4, 2022

ci pass
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/12755/pipeline

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 4, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d82fff8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2022
dsdashun
dsdashun approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@dsdashun dsdashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@dsdashun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 92c0050 into pingcap:master Aug 4, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 4, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#36878 to release-6.1
35fc007 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36881

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 4, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#36878 to release-6.2
913513b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36882

@D3Hunter D3Hunter deleted the retry-err branch August 4, 2022 04:52
@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 45 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 17 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 8 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Aug 4, 2022
@ti-srebot
lightning: retry on error on tikv ingest like 'stale command' (#36878) (
0da30a3 
#36882)

close #36877
ti-chi-bot pushed a commit that referenced this pull request Aug 5, 2022
@ti-srebot
lightning: retry on error on tikv ingest like 'stale command' (#36878) (
a6b5449 
#36881)

close #36877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@sleepymole sleepymole sleepymole approved these changes

@dsdashun dsdashun dsdashun approved these changes

@niubell niubell Awaiting requested review from niubell

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: retry on error like 'stale command' on tikv ingest
7 participants
@D3Hunter @ti-chi-bot @sre-bot @ti-srebot @dsdashun @sleepymole @buchuitoudegou